NOISSUE - Improve UI styling #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drasko <drasko.draskovic@gmail.com>
Signed-off-by: drasko <drasko.draskovic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 85.63% 85.58% -0.05%
==========================================
Files 64 64
Lines 4011 4011
==========================================
- Hits 3435 3433 -2
- Misses 394 395 +1
- Partials 182 183 +1
Continue to review full report at Codecov.
|
blokovi
approved these changes
Apr 18, 2019
|
LGTM |
| @@ -278,10 +278,10 @@ view model = | |||
| |> Card.header [] | |||
| [ Grid.row [] | |||
| [ Grid.col [ Col.attrs [ align "left" ] ] | |||
| [ h3 [ Spacing.mt2 ] [ text "Channels" ] | |||
| [ h3 [] [ div [ class "table_header" ] [ i [ style "margin-right" "15px", class faIcons.channels ] [], text "Channels" ] ] | |||
There was a problem hiding this comment.
Why do we need to have css style embedded inside html here?
| Card.config | ||
| [] | ||
| |> Card.headerH3 [] [ text title ] | ||
| |> Card.headerH3 [] [ div [ class "table_header" ] [ i [ style "margin-right" "15px", class faClass ] [], text title ] ] |
There was a problem hiding this comment.
Embedded css style attrib?
| (Html.map ChannelMsg (Helpers.genPagination model.channels.channels.total (Helpers.offsetToPage model.channels.offset model.channels.limit) Channel.SubmitPage)) | ||
| ) | ||
| ] | ||
| , Grid.row [] | ||
| [ Grid.col [] | ||
| [ Card.config [] | ||
| |> Card.headerH3 [] [ text "Message" ] | ||
| |> Card.headerH3 [] [ div [ class "table_header" ] [ i [ style "margin-right" "15px", class faIcons.messages ] [], text "Message" ] ] |
There was a problem hiding this comment.
This div repeats all over again. Better to make a helper func to generate this div.
darkodraskovic
approved these changes
Apr 18, 2019
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
* Add styling Signed-off-by: drasko <drasko.draskovic@gmail.com> * Fix errors Signed-off-by: drasko <drasko.draskovic@gmail.com> * Fix env Signed-off-by: drasko <drasko.draskovic@gmail.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
* Add styling Signed-off-by: drasko <drasko.draskovic@gmail.com> * Fix errors Signed-off-by: drasko <drasko.draskovic@gmail.com> * Fix env Signed-off-by: drasko <drasko.draskovic@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add styling Signed-off-by: drasko <drasko.draskovic@gmail.com> * Fix errors Signed-off-by: drasko <drasko.draskovic@gmail.com> * Fix env Signed-off-by: drasko <drasko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.