NOISSUE - Remove BS response empty channels check #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove empty list of channels check from the default Bootstrap reader implementation. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
- Coverage 85.63% 85.63% -0.01%
==========================================
Files 64 64
Lines 4011 4009 -2
==========================================
- Hits 3435 3433 -2
+ Misses 394 393 -1
- Partials 182 183 +1
Continue to review full report at Codecov.
|
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
Remove empty list of channels check from the default Bootstrap reader implementation. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
Remove empty list of channels check from the default Bootstrap reader implementation. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Remove empty list of channels check from the default Bootstrap reader implementation. Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request removes the unnecessary check if the given list of channels is empty when encoding Bootstrap config to Mainflux response.