NOISSUE - follow up of PR #657 #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 64 64
Lines 3993 3993
=======================================
Hits 3407 3407
Misses 399 399
Partials 187 187Continue to review full report at Codecov.
|
|
@chombium please resolve the conflicts. |
This commit, intruduces changes to the current behavior of the "make cleandocker" command. From now on, an extra parameter must be given in order to delete the persistent volumes, which up until now was done by default. The new command which represents the old behavior (deleting all artifacts created from the docker composition) is "make pv=true cleandocker". Signed-off-by: Jovan Kostovski <chombium@gmail.com>
chombium
force-pushed
the
ni-657-followup
branch
from
61957bb
to
0540450
Compare
|
@drasko done |
dborovcanin
approved these changes
Apr 20, 2019
|
Merged! Thanks @chombium ! |
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
This commit, intruduces changes to the current behavior of the "make cleandocker" command. From now on, an extra parameter must be given in order to delete the persistent volumes, which up until now was done by default. The new command which represents the old behavior (deleting all artifacts created from the docker composition) is "make pv=true cleandocker". Signed-off-by: Jovan Kostovski <chombium@gmail.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
This commit, intruduces changes to the current behavior of the "make cleandocker" command. From now on, an extra parameter must be given in order to delete the persistent volumes, which up until now was done by default. The new command which represents the old behavior (deleting all artifacts created from the docker composition) is "make pv=true cleandocker". Signed-off-by: Jovan Kostovski <chombium@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
This commit, intruduces changes to the current behavior of the "make cleandocker" command. From now on, an extra parameter must be given in order to delete the persistent volumes, which up until now was done by default. The new command which represents the old behavior (deleting all artifacts created from the docker composition) is "make pv=true cleandocker". Signed-off-by: Jovan Kostovski <chombium@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup of #657. After the @drasko's comment I remembered myself how many times we had complains that some user lost his/hers data because they were updating their Mainflux installation or recreated some of the
*-dbcontainers.This PR, introduces changes to the current behavior of the
make cleandockercommand.From now on, an extra parameter must be given in order to delete the persistent volumes, which up until now was done by default. The new command which represents the old behavior (deleting all artifacts created from the docker composition including the persistent volumes) is
make pv=true cleandocker.I understand that this might be a slight problem for the @mainflux/contributors as we'll have to use a new form of the command, but I agree with @drasko's comment that is better to be on the safe side and don't delete the data, the persistent volumes by default, although we, the @mainflux/contributors might have to run the command twice if we forget the
pv=trueparameter. A command alias would to the trick ;)