MF-525 - Add pagination response to the readers #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
- Coverage 85.32% 85.01% -0.31%
==========================================
Files 64 64
Lines 3993 4058 +65
==========================================
+ Hits 3407 3450 +43
- Misses 399 411 +12
- Partials 187 197 +10
Continue to review full report at Codecov.
|
manuio
suggested changes
Apr 23, 2019
nmarcetic
previously approved these changes
Apr 23, 2019
Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
nmarcetic
approved these changes
Apr 23, 2019
manuio
approved these changes
Apr 23, 2019
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
* Add pagination response to the readers Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Remove println from influx reader Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
* Add pagination response to the readers Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Remove println from influx reader Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add pagination response to the readers Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com> * Remove println from influx reader Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds pagination response for every reader.
Which issue(s) does this PR fix/relate to?
Resolves #525.
List any changes that modify/break current functionality
Readers response has now pagination metadata.
Have you included tests for your changes?
Yes, I've updated existing tests.
Did you document any new/modified functionality?
I've updated swagger docs.