NOISSUE - Fix Readers logs #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 85.39% 85.16% -0.23%
==========================================
Files 64 64
Lines 4230 4133 -97
==========================================
- Hits 3612 3520 -92
+ Misses 418 415 -3
+ Partials 200 198 -2
Continue to review full report at Codecov.
|
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
anovakovic01
suggested changes
May 7, 2019
readers/cassandra/messages_test.go
Outdated
| result, err := reader.ReadAll(tc.chanID, tc.offset, tc.limit, tc.query) | ||
| if err != nil { | ||
| assert.Equal(t, nil, err, fmt.Sprintf("%s: expected no error got %s", desc, err.Error())) | ||
| } |
There was a problem hiding this comment.
Don't use if err != nil {. Use assert.Nil instead of this if and assert.Equal.
readers/influxdb/messages_test.go
Outdated
| result, err := reader.ReadAll(tc.chanID, tc.offset, tc.limit, tc.query) | ||
| if err != nil { | ||
| assert.Equal(t, nil, err, fmt.Sprintf("%s: expected no error got %s", desc, err.Error())) | ||
| } |
There was a problem hiding this comment.
Same here, use assert.Nil instead.
readers/mongodb/messages_test.go
Outdated
| result, err := reader.ReadAll(tc.chanID, tc.offset, tc.limit, tc.query) | ||
| if err != nil { | ||
| assert.Equal(t, nil, err, fmt.Sprintf("%s: expected no error got %s", desc, err.Error())) | ||
| } |
There was a problem hiding this comment.
Same here, replace with assert.Nil.
readers/cassandra/messages.go
Outdated
| @@ -85,21 +87,21 @@ func (cr cassandraRepository) ReadAll(chanID string, offset, limit uint64, query | |||
| } | |||
|
|
|||
| if err := iter.Close(); err != nil { | |||
There was a problem hiding this comment.
Please ignore this error and move iter.Close() to line 44 of this file. So it should be defer iter.Close().
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
* NOISSUE - Fix Readers logs Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
* NOISSUE - Fix Readers logs Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Fix Readers logs Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com