NOISSUE - Add readers pagination in SDK #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
- Coverage 85.08% 85.03% -0.06%
==========================================
Files 64 64
Lines 4124 4129 +5
==========================================
+ Hits 3509 3511 +2
- Misses 417 420 +3
Partials 198 198
Continue to review full report at Codecov.
|
anovakovic01
suggested changes
May 7, 2019
sdk/go/sdk.go
Outdated
| @@ -168,7 +166,7 @@ type SDK interface { | |||
| SendMessage(chanID, msg, token string) error | |||
|
|
|||
| // ReadMessages read messages of specified channel. | |||
| ReadMessages(chanID, token string) ([]mainflux.Message, error) | |||
| ReadMessages(chanID, token string) (messagesPageRes, error) | |||
There was a problem hiding this comment.
You cannot use a private type for an interface return value. Please replace this with some public type and use messagesPageRes only internally in SDK in order to deserialize HTTP response.
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
* NOISSUE - Add readers pagination in SDK Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
* NOISSUE - Add readers pagination in SDK Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Add readers pagination in SDK Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com