Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add compile test to CI #743

Merged
merged 2 commits into from
May 13, 2019

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

Recently, we had CI problems because our main methods were broken, and tests are not covering the main methods. The code is compiled during the Docker Hub images update, so CI detected broken code and failed, but this only happens when merging code to the master branch. This pull request adds compilation checks to the CI script.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

No, this is just a CI script update.

Did you document any new/modified functionality?

There is no new or modified functionality.

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #743 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage    85.3%   85.26%   -0.05%     
==========================================
  Files          66       66              
  Lines        4220     4220              
==========================================
- Hits         3600     3598       -2     
- Misses        416      418       +2     
  Partials      204      204
Impacted Files Coverage Δ
things/service.go 90.79% <0%> (-1.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46164f...0eca864. Read the comment docs.

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit f5bb65d into absmach:master May 13, 2019
@dborovcanin dborovcanin deleted the update/ci-test-main branch May 14, 2019 10:31
rugwirobaker pushed a commit to rugwirobaker/mainflux that referenced this pull request Jun 26, 2019
* Add compile tests to CI script

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

* Fix parallelization flag

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Add compile tests to CI script

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>

* Fix parallelization flag

Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants