Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix CI with fixed plugin versions #747

Merged
merged 1 commit into from
May 15, 2019

Conversation

anovakovic01
Copy link
Contributor

What does this do?

Fixes the current CI setup by fixing plugin versions.

scripts/ci.sh Outdated
git checkout v1.3.1
go install github.com/golang/protobuf/protoc-gen-go

cd $GOPATH/src/github.com/gogo/protobuf/protoc-gen-gofast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not aligned

@anovakovic01 anovakovic01 force-pushed the NOISSUE-fix-ci branch 7 times, most recently from 5e4cbf5 to bb82917 Compare May 15, 2019 13:09
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #747 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #747   +/-   ##
======================================
  Coverage    85.3%   85.3%           
======================================
  Files          66      66           
  Lines        4220    4220           
======================================
  Hits         3600    3600           
  Misses        416     416           
  Partials      204     204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bb65d...51f62b7. Read the comment docs.

@anovakovic01 anovakovic01 marked this pull request as ready for review May 15, 2019 15:30
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit cc5c66b into absmach:master May 15, 2019
rugwirobaker pushed a commit to rugwirobaker/mainflux that referenced this pull request Jun 26, 2019
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants