NOISSUE - Fix count when search by name is performed #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
======================================
Coverage 85.2% 85.2%
======================================
Files 69 69
Lines 4630 4630
======================================
Hits 3945 3945
Misses 445 445
Partials 240 240Continue to review full report at Codecov.
|
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
nmarcetic
approved these changes
Jun 21, 2019
|
@dusanb94 Please update branch |
manuio
approved these changes
Jun 22, 2019
rugwirobaker
pushed a commit
to rugwirobaker/mainflux
that referenced
this pull request
Jun 26, 2019
* Fix total field when search by name Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix tests to check total count Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix total field when search by name Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Fix tests to check total count Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request fixes
totalvalue in the page response when filter by name is applied.List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes, the docs are updated in #766.