NOISSUE - Add content type as part of MQTT subscription topic #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Remove default content type value (SenML JSON) and replace it with an empty string. Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 85.29% 85.37% +0.07%
==========================================
Files 72 72
Lines 4653 4651 -2
==========================================
+ Hits 3969 3971 +2
+ Misses 455 452 -3
+ Partials 229 228 -1
Continue to review full report at Codecov.
|
dborovcanin
approved these changes
Jul 29, 2019
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add content type to MQTT sub topic Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Remove default content type value Remove default content type value (SenML JSON) and replace it with an empty string. Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update docs in accordance with changes Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds content type as part of MQTT subscription topic.
Which issue(s) does this PR fix/relate to?
There is no issue for this PR.
List any changes that modify/break current functionality
The default value for content type is not SenML JSON, but an empty string.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
I've updated existing docs.