Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add config to writers docs #812

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

anovakovic01
Copy link
Contributor

What does this do?

Adds config explanation to writers docs.

Which issue(s) does this PR fix/relate to?

There is no PR for this update.

List any changes that modify/break current functionality

There are none.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

Yes.

Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
@codecov-io
Copy link

codecov-io commented Jul 31, 2019

Codecov Report

Merging #812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files          72       72           
  Lines        4651     4651           
=======================================
  Hits         3971     3971           
  Misses        452      452           
  Partials      228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c751d0e...897756b. Read the comment docs.

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 68e8eda into absmach:master Aug 1, 2019
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants