Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-295 add mqtt benchmark tool #817

Merged
merged 27 commits into from
Aug 13, 2019
Merged

MF-295 add mqtt benchmark tool #817

merged 27 commits into from
Aug 13, 2019

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Aug 6, 2019

What does this do?

benchmark mqtt broker

Which issue(s) does this PR fix/relate to?

Resolves #295

Yes

@mteodor
adding mqtt benchmark tool
6cec165 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
adding mqtt benchmark tool - vendoring
808994a 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
add mtls support
7a78f42 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
update readme
a17c5b4 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@codecov-io
Copy link

codecov-io commented Aug 6, 2019 •
edited
Loading

Codecov Report

Merging #817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files          72       72           
  Lines        4701     4701           
=======================================
  Hits         4023     4023           
  Misses        442      442           
  Partials      236      236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a78b11...e83b546. Read the comment docs.

drasko
drasko requested changes Aug 6, 2019
View reviewed changes
benchmark/README.md Outdated Show resolved Hide resolved
benchmark/README.md Outdated Show resolved Hide resolved
benchmark/connections.json Outdated Show resolved Hide resolved
benchmark/main.go Outdated Show resolved Hide resolved
benchmark/main.go Outdated Show resolved Hide resolved
benchmark/main.go Outdated
fmt.Println(string(out.Bytes()))
default:
for _, res := range results {
fmt.Printf("======= CLIENT %s =======\n", res.ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use Aurora package to add some colors in the CLI and make is sexier ;).

benchmark/onechannel.json Outdated Show resolved Hide resolved
drasko
drasko requested changes Aug 6, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
dborovcanin
dborovcanin requested changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need client binary in /benchmark?

benchmark/main.go Outdated Show resolved Hide resolved
benchmark/client.go Outdated Show resolved Hide resolved
@mteodor
tool for channel provision, reorganize code
186d238 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
adding config toml
5cb17fa 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
tool for channel provision, adding ssl cert gen
d375748 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
add config toml
c56bc6e 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
add readme for provision
841195b 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
update readme
7f1d48c 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
remove some printing
fa77401 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
add test configs
bfcf434 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
drasko
drasko requested changes Aug 8, 2019
View reviewed changes
tools/provision/main.go Outdated Show resolved Hide resolved
tools/provision/main.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/client.go Outdated Show resolved Hide resolved
@mteodor
remove some dead code, and sort comments
5c895ab 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
replace statistics lib
f87b3c8 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
replace statistics lib
d1780f8 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
add cobra and viper
95a3f15 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
dborovcanin
dborovcanin requested changes Aug 9, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
tools/mqtt-bench/mqtt/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/mqtt/client.go Outdated Show resolved Hide resolved
tools/mqtt-bench/mqtt/client.go Outdated Show resolved Hide resolved
tools/provision/main.go Outdated Show resolved Hide resolved
@mteodor
styling changes
afce630 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
styling changes
3239aef 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
styling changes
1e2ed9a 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
remove statistic lib
c94b393 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
change type visibility
2b475ca 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
remove empty line
fa6609f 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
dborovcanin
dborovcanin previously approved these changes Aug 12, 2019
View reviewed changes
anovakovic01
anovakovic01 suggested changes Aug 12, 2019
View reviewed changes
Gopkg.toml Outdated Show resolved Hide resolved
tools/mqtt-bench/cmd/bench.go Outdated Show resolved Hide resolved
tools/mqtt-bench/cmd/bench.go Outdated Show resolved Hide resolved
@mteodor
update vendor
47cabde 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
update deps
dfca5e1 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
rename variable
72f0826 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor
small changes, adding comments
1d5efaa 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
anovakovic01
anovakovic01 suggested changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just handle these errors and it will be approved. Sorry for not specifying this earlier, I missed it somehow.

tools/mqtt-bench/cmd/bench.go Outdated Show resolved Hide resolved
tools/provision/main.go Show resolved Hide resolved
tools/mqtt-bench/cmd/bench.go Outdated Show resolved Hide resolved
tools/mqtt-bench/mqtt/client.go Outdated Show resolved Hide resolved
@mteodor
error handling
e83b546 
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
anovakovic01
anovakovic01 approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

drasko
drasko approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 19834df into absmach:master Aug 13, 2019
@nmarcetic nmarcetic mentioned this pull request Oct 9, 2019
Closed
@mteodor mteodor deleted the MF-295 branch September 22, 2020 10:38
manuio pushed a commit that referenced this pull request Oct 12, 2020
@mteodor @drasko
MF-295 add mqtt benchmark tool (#817)
b0755df 
* adding mqtt benchmark tool

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* adding mqtt benchmark tool - vendoring

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* add mtls support

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* update readme

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* tool for channel provision, reorganize code

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* adding config toml

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* tool for channel provision, adding ssl cert gen

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* add config toml

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* add readme for provision

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* update readme

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* remove some printing

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* add test configs

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* remove some dead code, and sort comments

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* replace statistics lib

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* replace statistics lib

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* add cobra and viper

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* styling changes

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* styling changes

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* styling changes

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* remove statistic lib

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* change type visibility

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* remove empty line

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* update vendor

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* update deps

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* rename variable

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* small changes, adding comments

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

* error handling

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@anovakovic01 anovakovic01 anovakovic01 approved these changes

@dborovcanin dborovcanin dborovcanin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mteodor @codecov-io @drasko @anovakovic01 @dborovcanin