MF-832 Invalid Content-Type in MQTT Version Endpoint, MF-822 Return 404 for non /version paths on MQTT adapter
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parham Alvani <parham.alvani@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #837 +/- ##
=======================================
Coverage 85.58% 85.58%
=======================================
Files 72 72
Lines 4702 4702
=======================================
Hits 4024 4024
Misses 442 442
Partials 236 236Continue to review full report at Codecov.
|
nmarcetic
approved these changes
Sep 4, 2019
| if (req.url === '/version') { | ||
| res.statusCode = 200; | ||
| res.setHeader('Content-Type', 'text/plain; charset=utf-8'); | ||
| res.end(`{"service":"mqtt-adapter","version":"${version}"}`); |
There was a problem hiding this comment.
We don't use template literals (e.g mixing with ES6). Just a tip, but we should consider refactoring and using ES6.
|
Please change issue name to something like |
1995parham
changed the title
/version paths on MQTT adapter
|
@drasko I have changed the title to issues that this pull request resolves. |
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Parham Alvani <parham.alvani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It fixes content-type and not-found issues in MQTT version endpoint. if you use invalid route instead of getting empty response you get 404 error with a not-found message.
Which issue(s) does this PR fix/relate to?
Resolve #832
Resolve #822
List any changes that modify/break current functionality
It doesn't break or change current functionality.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes