NOISSUE - Add measuring time from pub to sub #839

mteodor · 2019-09-05T07:06:24Z

What does this do?

add measuring of time from publishing up to receiving a message in subscriber
synchronize publishers and subscribers on start end end of publishing
add a test message that can be normalized

codecov-io · 2019-09-05T07:13:48Z

Codecov Report

Merging #839 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          72       72           
  Lines        4702     4702           
=======================================
  Hits         4024     4024           
  Misses        442      442           
  Partials      236      236

Impacted Files	Coverage Δ
writers/postgres/init.go	`89.74% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115d94b...72e2f53. Read the comment docs.

anovakovic01 · 2019-09-05T09:25:47Z

tools/mqtt-bench/client.go

 		if err != nil {
-			log.Printf("Client %s failed to decode message\n", clientID)
+			//log.Printf("Failed to decode message %s\n", err.Error())


Remove the code that is commented out.

anovakovic01 · 2019-09-05T09:26:50Z

tools/mqtt-bench/templates/config.toml

+=======
+pubs = 1 
+subs = 1
+>>>>>>> improve sync between pub and sub


You've committed conflict marks. Please resolve them.

anovakovic01 · 2019-09-05T09:27:33Z

tools/mqtt-bench/bench.go

 }

 // Benchmark - main benckhmarking function
 func Benchmark(cfg Config) {
 	var wg sync.WaitGroup
 	var err error

-	checkConnection(cfg.MQTT.Broker.URL, 1)
-	subTimes := make(SubTimes)
+	//checkConnection(cfg.MQTT.Broker.URL, 1)


Remove the code that is commented out.

drasko · 2019-09-05T14:54:48Z

tools/mqtt-bench/bench.go

+		log.Fatalf("Failed to create test message")
+	}
+
+	// how many records to make message long sz bytes


Comments start with capital letters

drasko · 2019-09-05T14:54:57Z

tools/mqtt-bench/bench.go

+	records := make([]senml.SenMLRecord, n)
+	records[0] = timeStamp
+	for i := 1; i < n; i++ {
+		// is this needed


Remove dead code

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

drasko

LGTM

anovakovic01

LGTM!

* refactor code Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * connect each thing with each channel Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reverting - structure fields must be exported Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reverting - structure fields must be exported Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert some names Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * move meausuring time start Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add pub-to-sub delivery time measure Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add pub-to-sub delivery time measure Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add pub-to-sub delivery time measure Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add pub-to-sub delivery time measure Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * improve sync between pub and sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * improve sync between pub and sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * improve sync between pub and sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * improve sync between pub and sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * improve sync between pub and sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * improve sync between pub and sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add random payload Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert changes for config.toml Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add random payload Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove printfs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add logging Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add payload Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add payload Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * rename variable Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add payload Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor sync Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor sync Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor results Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change sync and result collecting for sub Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor added the work-in-progress label Sep 5, 2019

anovakovic01 suggested changes Sep 5, 2019

View reviewed changes

dborovcanin previously approved these changes Sep 5, 2019

View reviewed changes

mteodor dismissed dborovcanin’s stale review via 1c98259 September 5, 2019 11:27

mteodor force-pushed the e2e-time branch from 1c98259 to a1e307b Compare September 5, 2019 11:56

drasko changed the title ~~NOISSUE - add measuring time from pub to sub~~ NOISSUE - Add measuring time from pub to sub Sep 5, 2019

drasko requested changes Sep 5, 2019

View reviewed changes

mteodor force-pushed the e2e-time branch from 1b7b281 to 1c38893 Compare September 6, 2019 09:45

mteodor removed the work-in-progress label Sep 6, 2019

mteodor added 20 commits September 6, 2019 11:52

refactor code

a81f404

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

connect each thing with each channel

fb5cd12

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

reverting - structure fields must be exported

68003d2

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

reverting - structure fields must be exported

f6e4d23

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

revert some names

1a12835

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

move meausuring time start

1c4a008

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add pub-to-sub delivery time measure

b276e84

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add pub-to-sub delivery time measure

b3ed709

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add pub-to-sub delivery time measure

def3917

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add pub-to-sub delivery time measure

90616a3

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

improve sync between pub and sub

94f992a

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

improve sync between pub and sub

ac92109

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

improve sync between pub and sub

d7bd2f1

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

improve sync between pub and sub

16d9a53

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

improve sync between pub and sub

66a3f34

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

improve sync between pub and sub

e85defd

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add random payload

3644847

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

revert changes for config.toml

4f7d10b

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add random payload

92a1975

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove printfs

63ad958

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor added 11 commits September 6, 2019 11:52

add logging

5a82bf4

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add payload

ef4cf2b

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add payload

25b444a

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

rename variable

1a0194c

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add payload

897302c

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

small changes

2ce4606

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor sync

26f410f

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor sync

e69e91d

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

refactor results

1098353

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

change sync and result collecting for sub

b451204

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

fix comments

72e2f53

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor force-pushed the e2e-time branch from 1c38893 to 72e2f53 Compare September 6, 2019 09:57

drasko approved these changes Sep 6, 2019

View reviewed changes

dborovcanin approved these changes Sep 6, 2019

View reviewed changes

anovakovic01 approved these changes Sep 6, 2019

View reviewed changes

anovakovic01 merged commit 97327ab into absmach:master Sep 6, 2019

mteodor deleted the e2e-time branch September 22, 2020 10:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Add measuring time from pub to sub #839

NOISSUE - Add measuring time from pub to sub #839

mteodor commented Sep 5, 2019

codecov-io commented Sep 5, 2019 •

edited

Loading

anovakovic01 Sep 5, 2019

anovakovic01 Sep 5, 2019

anovakovic01 Sep 5, 2019

drasko Sep 5, 2019

drasko Sep 5, 2019

drasko left a comment

anovakovic01 left a comment

NOISSUE - Add measuring time from pub to sub #839

NOISSUE - Add measuring time from pub to sub #839

Conversation

mteodor commented Sep 5, 2019

What does this do?

codecov-io commented Sep 5, 2019 • edited Loading

Codecov Report

anovakovic01 Sep 5, 2019

Choose a reason for hiding this comment

anovakovic01 Sep 5, 2019

Choose a reason for hiding this comment

anovakovic01 Sep 5, 2019

Choose a reason for hiding this comment

drasko Sep 5, 2019

Choose a reason for hiding this comment

drasko Sep 5, 2019

Choose a reason for hiding this comment

drasko left a comment

Choose a reason for hiding this comment

anovakovic01 left a comment

Choose a reason for hiding this comment

codecov-io commented Sep 5, 2019 •

edited

Loading