-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Upgrade Go version to 1.13 in container images #868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 85.45% 85.49% +0.04%
==========================================
Files 72 72
Lines 4744 4744
==========================================
+ Hits 4054 4056 +2
+ Misses 451 450 -1
+ Partials 239 238 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot be accepted before CI is fixed as well. I.e. this PR must contain changes in CI script.
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Add new go installation to PATH Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Change go version to 1.13 in docker images Signed-off-by: Ivan Milošević <iva@blokovi.com> * update go version on CI Signed-off-by: Ivan Milošević <iva@blokovi.com> * fix and add debug code in ci.sh Signed-off-by: Ivan Milošević <iva@blokovi.com> * Remove other Go version from PATH on semaphoreci Add new go installation to PATH Signed-off-by: Ivan Milošević <iva@blokovi.com> * Create dir for golang 1.13 Signed-off-by: Ivan Milošević <iva@blokovi.com> * remove debug code Signed-off-by: Ivan Milošević <iva@blokovi.com> * Add check for current go version before upgrade in ci script Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević iva@blokovi.com
What does this do?
Upgrade Go to ver. 1.13 in container images
Which issue(s) does this PR fix/relate to?
No issue