Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Upgrade Go version to 1.13 in container images #868

Merged
merged 7 commits into from
Sep 23, 2019

Conversation

blokovi
Copy link
Contributor

@blokovi blokovi commented Sep 19, 2019

Signed-off-by: Ivan Milošević iva@blokovi.com

What does this do?

Upgrade Go to ver. 1.13 in container images

Which issue(s) does this PR fix/relate to?

No issue

@blokovi blokovi requested a review from a team as a code owner September 19, 2019 16:00
@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #868 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   85.45%   85.49%   +0.04%     
==========================================
  Files          72       72              
  Lines        4744     4744              
==========================================
+ Hits         4054     4056       +2     
+ Misses        451      450       -1     
+ Partials      239      238       -1
Impacted Files Coverage Δ
ws/api/transport.go 89.06% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8cb265...6f95e46. Read the comment docs.

anovakovic01
anovakovic01 previously approved these changes Sep 20, 2019
Copy link
Contributor

@anovakovic01 anovakovic01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be accepted before CI is fixed as well. I.e. this PR must contain changes in CI script.

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Add new go installation to PATH

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Signed-off-by: Ivan Milošević <iva@blokovi.com>
scripts/ci.sh Outdated Show resolved Hide resolved
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 5e3bb27 into absmach:master Sep 23, 2019
@blokovi blokovi deleted the gover branch April 6, 2020 18:26
manuio pushed a commit that referenced this pull request Oct 12, 2020
* Change go version to 1.13 in docker images

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* update go version on CI

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* fix and add debug code in ci.sh

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Remove other Go version from PATH on semaphoreci
Add new go installation to PATH

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Create dir for golang 1.13

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* remove debug code

Signed-off-by: Ivan Milošević <iva@blokovi.com>

* Add check for current go version before upgrade in ci script

Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants