MF-532 - Password reset #873

mteodor · 2019-09-30T14:16:28Z

What does this do?

adding endpoints for password resetting flow
Adds an endpoint for changing password of currently authenticated user

Which issue(s) does this PR fix/relate to?

Resolves #532 ( option 1. from https://github.com/mainflux/mainflux/issues/532#issuecomment-450579158)

codecov-io · 2019-10-04T09:56:14Z

Codecov Report

Merging #873 into master will decrease coverage by 0.91%.
The diff coverage is 62.31%.

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   84.54%   83.63%   -0.92%     
==========================================
  Files          74       75       +1     
  Lines        4879     5083     +204     
==========================================
+ Hits         4125     4251     +126     
- Misses        513      584      +71     
- Partials      241      248       +7

Impacted Files	Coverage Δ
users/users.go	`68.42% <ø> (ø)`	⬆️
users/postgres/users.go	`54.54% <0%> (-17.46%)`	⬇️
users/api/http/responses.go	`66.66% <100%> (+16.66%)`	⬆️
users/api/http/endpoint.go	`86.2% <100%> (+18.2%)`	⬆️
users/service.go	`28.57% <5%> (-33.93%)`	⬇️
users/api/http/requests.go	`61.53% <70%> (+28.2%)`	⬆️
users/token/token.go	`71.42% <71.42%> (ø)`
users/api/http/transport.go	`82.08% <84.37%> (+1.8%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6687a73...d48d556. Read the comment docs.

things/swagger.yaml

users/api/http/transport.go

anovakovic01 · 2019-10-07T09:11:48Z

users/api/http/endpoint.go

@@ -27,6 +28,54 @@ func registrationEndpoint(svc users.Service) endpoint.Endpoint {
 	}
 }

+// Password reset endpoint serves post request with email of the user
+// for whom password reset flow is to be initiated.
+// If request is succsesfull email with reset link will be sent to the


Correct successful.

anovakovic01 · 2019-10-07T09:13:47Z

users/api/http/endpoint.go

+// email specified in the request.
+// Link contains token that has TTL that needs to be verified.
+// When user gets email with reset password link this endpoint can serve
+// that request and return response into the ui form which than can


Correct then.

users/api/http/endpoint.go

anovakovic01 · 2019-10-07T09:34:10Z

users/api/http/responses.go

+
+type resetPassRes struct {
+	Msg   string `json:"msg"`
+	Error string `json:"error"`


I'm not sure if you should have an error here. @blokovi is working on the PR that should tackle error handling and HTTP error response.

I'm not sure either, but something needs to be displayed in frontend. For example if token is expired. We can remove this error. Maybe that "token expired", and "non-existent" user messages can be in Msg field.

users/api/http/endpoint.go

anovakovic01 · 2019-10-07T09:47:24Z

users/postgres/users.go

+	}
+	db := struct {
+		Email string
+		Token string


Please add db tags here.

anovakovic01 · 2019-10-07T09:48:11Z

users/api/http/requests.go

+type resetTokenReq struct {
+	Token    string
+	Email    string
+	Password string


If these are json fields, please add json tags.

I would move the token in URL and send password and re-passowrd, don't need a email.

anovakovic01 · 2019-10-07T09:48:24Z

users/api/http/requests.go

+
+type passwResetReq struct {
+	Email string
+	Host  string


If these are json fields, please add json tags.

What's the host field ?

Host is extracted from the referer header, it is used for construction of the reset link

users/api/http/transport.go

anovakovic01 · 2019-10-07T09:53:44Z

users/token/token.go

+	tokenLength   = ttlLength + emailLength // Max token length is 4 bytes + max email length
+	hashCost      = 10
+	tokenDuration = 5                      // Recovery token TTL in minutes, reperesents token time to live
+	secret        = "fcERNb7KpM3WyAmguJMZ" // Random string for secret key, required for signing


You should probably move this to the env var if you haven't already. Also, I recommend that you use https://github.com/dgrijalva/jwt-go here.

IMHO JWT is too big plus Verify() must include DB query to compare stored token and token we get which also means we need to hash JWT and save it in DB.

users/api/http/endpoint_test.go

drasko · 2019-10-07T18:18:35Z

users/api/http/endpoint_test.go

+		Password string
+		Token    string
+	}{}
+	// this probably needs to be moved somwhere else


Comments start with capital letters. You can also skip a line here.

users/api/http/endpoint_test.go

users/api/http/transport.go

users/mail/mail.go

users/service.go

drasko · 2019-10-07T18:22:03Z

users/service.go

+	ErrRetrievingRecoveryToken = errors.New("error deleting recovery token")
+
+	// ErrMisingResetToken indicates malformed or missing reset token
+	// for reseting password.


No fullstop

users/service.go

drasko · 2019-10-07T18:22:28Z

users/service.go

@@ -51,6 +77,13 @@ type Service interface {

 	// Get authenticated user info for the given token.


No fullstop

users/token/token.go

users/api/http/endpoint_test.go

users/mail/mail.go

manuio · 2019-10-08T14:32:00Z

docker/docker-compose.yml

+      MF_MAIL_DRIVER: ${MF_MAIL_DRIVER}
+      MF_MAIL_HOST: ${MF_MAIL_HOST}
+      MF_MAIL_PORT: ${MF_MAIL_PORT}
+      MF_MAIL_USERNAME: ${MF_MAIL_USERNAME}
+      MF_MAIL_PASSWORD: ${MF_MAIL_PASSWORD}
+      MF_MAIL_FROM_ADDRESS: ${MF_MAIL_FROM_ADDRESS}
+      MF_MAIL_FROM_NAME: ${MF_MAIL_FROM_NAME}


I would use EMAIL instead of MAIL for all envars

manuio · 2019-10-08T14:32:40Z

users/README.md

+| MF_MAIL_DRIVER            | Mail server driver, mail server for sending reset password token        | smtp           |
+| MF_MAIL_HOST              | Mail server host                                                        | localhost      |
+| MF_MAIL_PORT              | Mail server port                                                        | 25             |
+| MF_MAIL_USERNAME          | Mail server username                                                    |                |
+| MF_MAIL_PASSWORD          | Mail server password                                                    |                |
+| MF_MAIL_FROM_ADDRESS      | Mail "from" address                                                     |                |
+| MF_MAIL_FROM_NAME         | Mail "from" name                                                        |                |


manuio · 2019-10-08T14:32:51Z

users/README.md

+      MF_MAIL_DRIVER: [Mail server driver smtp]
+      MF_MAIL_HOST: [MF_MAIL_HOST]
+      MF_MAIL_PORT: [MF_MAIL_PORT]
+      MF_MAIL_USERNAME: [MF_MAIL_USERNAME]
+      MF_MAIL_PASSWORD: [MF_MAIL_PASSWORD]
+      MF_MAIL_FROM_ADDRESS: [MF_MAIL_FROM_ADDRESS]
+      MF_MAIL_FROM_NAME: [MF_MAIL_FROM_NAME]


users/mail/mail.go

.env

users/mail/mail.go

.env

users/README.md

users/api/http/endpoint_test.go

users/api/http/responses.go

users/mail/mail.go

drasko · 2019-10-09T20:16:14Z

users/service.go

+}
+
+func (svc usersService) GenerateResetToken(ctx context.Context, email, host string) error {
+


No need for empty line here.

users/mocks/users.go

tools/mqtt-bench/client.go

drasko · 2019-10-09T21:34:15Z

users/users.go

@@ -44,6 +44,9 @@ type UserRepository interface {

 	// RetrieveByID retrieves user by its unique identifier (i.e. email).
 	RetrieveByID(context.Context, string) (User, error)
+
+	// UpdatePassword(


Please correct this comment

drasko · 2019-10-09T21:35:23Z

users/token/token.go

@@ -0,0 +1,155 @@
+//Package token provides password recovery token generation with TTL
+//Token is sent by email to user as part of recovery URL


Put a space behind //

users/api/http/endpoint_test.go

users/api/http/endpoint.go

users/api/http/transport.go

anovakovic01 · 2019-10-10T11:22:01Z

users/mail/mail.go

+	envMailPassword    = "MF_MAIL_PASSWORD"
+	envMailFromAddress = "MF_MAIL_FROM_ADDRESS"
+	envMailFromName    = "MF_MAIL_FROM_NAME"
+	envMailLogLevel    = "MF_MAIL_LOG_LEVEL"


I think that these should be in the cmd/users/main.go

anovakovic01 · 2019-10-10T11:24:53Z

users/mail/mail.go

+
+		a.log = logger
+	})
+	return a


All of the env vars should be loaded in the main. You can create a separate mail config structure here and pass this mail config as method parameter.

OK, but this way mail can be reused in any other service with just calling mail.Send and providing environment variables, no need to handle configs in main of the service

users/service.go

users/token/token.go

drasko · 2019-10-11T21:59:36Z

users/token/token.go

+	return email, nil
+}
+
+// // SendToken sends password recovery link to user


Please remove dead code

drasko · 2019-10-11T22:00:16Z

users/token/token.go

+
+type tokenizer struct {
+	hmacSampleSecret []byte // secret for signing token
+	tokenDuration    int    //token in duration in min


Please add space after //

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

manuio

LGTM

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

anovakovic01

LGTM!

configs/resetPasswEmail.tmpl

users/api/http/endpoint.go

users/emailer/emailer.go

users/service.go

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

manuio

LGTM

* add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * when metadata is not set dont save 'null' string Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * when metadata is not set dont save 'null' string Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * when metadata is not set dont save 'null' string Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change metadata type, add error handling Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change metadata type, add error handling Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change metadata type, add error handling Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove extra char Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove extra char Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove extra char Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * few small fixes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * few small fixes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * few small fixes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix identityRes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix identityRes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix identityRes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * mail Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * mail Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reset request endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reset request endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reset request endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token methods Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token methods Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token methods Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding token endpoints Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding token endpoints Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding token endpoints Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding reset passw endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding reset passw endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding reset passw endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add logic for token verifying Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add logic for token verifying Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add logic for token verifying Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove mail from main Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove mail from main Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove mail from main Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * token and passwd update logic Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * token and passwd update logic Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * token and passwd update logic Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize mailing code Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add comments for password reset flow Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add comments for password reset flow Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change struct members to private Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add space Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add space Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add space Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert back changes used for testing Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert back changes used for testing Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert back changes used for testing Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize endpoints, extract host for link from Referer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize endpoints, extract host for link from Referer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding swagger docs for reset passw Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding swagger docs for reset passw Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix imports and some typos Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix imports and some typos Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding swagger docs for reset passw Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize endpoints, extract host for link from Referer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize endpoints, extract host for link from Referer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * addint test and update swagger for pass reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * addint test and update swagger for pass reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * addint test and update swagger for pass reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding test for endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding test for endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding test for endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding test for endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding endpoint test Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding endpoint test Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding endpoint test Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change token generation Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change token generation Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change token generation Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize and change token gen Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize and change token gen Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize and change token gen Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * addint token and mail Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding token env Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding token env Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix error reporting Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix some comments and update readme Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix some comments and update readme Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix some comments and update readme Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update readme Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix problmes due merge Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix problmes due merge Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix typos Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix typos Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add trusted certificates Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add endpoint for password change of currently authenticated user Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add env variable for conf reset endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add metadata to users Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add default value for metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * when metadata is not set dont save 'null' string Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change metadata type, add error handling Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove extra char Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * few small fixes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix identityRes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add users metadata Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * password reset, sketching Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reset request endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding token endpoints Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding reset passw endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add logic for token verifying Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove mail from main Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small changes Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add space Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert back changes used for testing Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize endpoints, extract host for link from Referer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize endpoints, extract host for link from Referer Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * addint test and update swagger for pass reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * adding endpoint test Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix some comments and update readme Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add env variable for conf reset endpoint Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix tests Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * resolving some style comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * minor fixes due to bad merge Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix problem with unsigned commits Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix problem with unsigned commits Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix call to users.New Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix call to users.New Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * rename file Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * rename to email.go Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * additional comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * additional comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor email util Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor email util Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor email util Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor email util Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove debug bin Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add driver conf for mail Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor email Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * refactor email Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix failing tests Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add testify Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small fix Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add token conf Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small fix Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small fix Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * configurable email template Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix missing var Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add env for email template file Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add env for email template file Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix tests Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix test Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix test Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * revert to master Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove dev container Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small fixes, typos, namings Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * fix typo Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * resolving comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * resolving comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * resolving comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * resolving comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * resolving comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add line Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * return err from email New() Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * change MF_TOKEN_RESET_ENDPOINT Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * add and remove env vars Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * separate password logic into two methods Change and Reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update comments Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * remove blank line Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * update docs Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * dont use camel case Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * small fix Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize email template for passw reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com> * reorganize email template for passw reset Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor requested a review from a team as a code owner September 30, 2019 14:16

mteodor added the work-in-progress label Sep 30, 2019

mteodor changed the title ~~NOISSUE - Password change~~ MF-532 - Password change Oct 1, 2019

mteodor force-pushed the password-change branch from ae40e53 to b28200a Compare October 2, 2019 12:36

manuio suggested changes Oct 4, 2019

View reviewed changes

things/swagger.yaml Outdated Show resolved Hide resolved

manuio reviewed Oct 5, 2019

View reviewed changes

users/api/http/transport.go Outdated Show resolved Hide resolved

anovakovic01 suggested changes Oct 7, 2019

View reviewed changes

drasko requested changes Oct 7, 2019

View reviewed changes

manuio suggested changes Oct 8, 2019

View reviewed changes

users/api/http/endpoint_test.go Outdated Show resolved Hide resolved

manuio suggested changes Oct 8, 2019

View reviewed changes

users/mail/mail.go Outdated Show resolved Hide resolved

mteodor force-pushed the password-change branch from 5ebb6ef to 526e3fc Compare October 8, 2019 11:49

mteodor removed the work-in-progress label Oct 8, 2019

manuio suggested changes Oct 8, 2019

View reviewed changes

nmarcetic mentioned this pull request Oct 9, 2019

New Feature Request- Need an API to retrieve old Password #532

Closed

mteodor changed the title ~~MF-532 - Password change~~ MF-532 - Password reset Oct 9, 2019

manuio suggested changes Oct 9, 2019

View reviewed changes

users/mail/mail.go Outdated Show resolved Hide resolved

users/mail/mail.go Outdated Show resolved Hide resolved

.env Outdated Show resolved Hide resolved

manuio suggested changes Oct 9, 2019

View reviewed changes

drasko requested changes Oct 9, 2019

View reviewed changes

mteodor force-pushed the password-change branch from 1136b0e to dff2e73 Compare October 10, 2019 00:38

anovakovic01 suggested changes Oct 10, 2019

View reviewed changes

drasko requested changes Oct 11, 2019

View reviewed changes

mteodor force-pushed the password-change branch 3 times, most recently from 0074eb9 to 462e0ed Compare October 13, 2019 13:27

mteodor mentioned this pull request Oct 13, 2019

MF-532 - Password change for authenticated user #880

Closed

mteodor force-pushed the password-change branch 2 times, most recently from 30f5842 to aeccf9a Compare October 13, 2019 13:50

mteodor added 12 commits October 22, 2019 11:00

resolving comments

4ecb2a3

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

resolving comments

87a8e0a

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

resolving comments

2986d71

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add line

1761465

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

return err from email New()

06c82fc

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

change MF_TOKEN_RESET_ENDPOINT

28ba636

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

add and remove env vars

f0c28ef

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

separate password logic into two methods Change and Reset

5e4fe5d

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

update comments

d73ca7e

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

remove blank line

2c9c52f

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

update docs

4dedd3c

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

dont use camel case

e05a4d0

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

manuio previously approved these changes Oct 22, 2019

View reviewed changes

dborovcanin previously approved these changes Oct 22, 2019

View reviewed changes

mteodor dismissed stale reviews from dborovcanin and manuio via e05a4d0 October 22, 2019 09:16

mteodor force-pushed the password-change branch from a76c857 to e05a4d0 Compare October 22, 2019 09:16

dborovcanin previously approved these changes Oct 22, 2019

View reviewed changes

small fix

d48d556

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor dismissed dborovcanin’s stale review via d48d556 October 22, 2019 10:27

anovakovic01 previously approved these changes Oct 22, 2019

View reviewed changes

nmarcetic reviewed Oct 22, 2019

View reviewed changes

configs/resetPasswEmail.tmpl Show resolved Hide resolved

users/api/http/endpoint.go Show resolved Hide resolved

users/emailer/emailer.go Outdated Show resolved Hide resolved

users/service.go Outdated Show resolved Hide resolved

mteodor added 2 commits October 22, 2019 13:30

reorganize email template for passw reset

bc04947

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

reorganize email template for passw reset

8aae17d

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>

mteodor dismissed anovakovic01’s stale review via 8aae17d October 22, 2019 11:31

nmarcetic approved these changes Oct 22, 2019

View reviewed changes

manuio approved these changes Oct 22, 2019

View reviewed changes

manuio merged commit f4f938a into absmach:master Oct 22, 2019

mteodor deleted the password-change branch September 22, 2020 10:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MF-532 - Password reset #873

MF-532 - Password reset #873

mteodor commented Sep 30, 2019 •

edited

Loading

codecov-io commented Oct 4, 2019 •

edited

Loading

anovakovic01 Oct 7, 2019

anovakovic01 Oct 7, 2019

anovakovic01 Oct 7, 2019

mteodor Oct 7, 2019

anovakovic01 Oct 7, 2019

anovakovic01 Oct 7, 2019

nmarcetic Oct 7, 2019

anovakovic01 Oct 7, 2019

nmarcetic Oct 7, 2019

mteodor Oct 8, 2019 •

edited

Loading

anovakovic01 Oct 7, 2019

nmarcetic Oct 7, 2019

drasko Oct 7, 2019

drasko Oct 7, 2019

drasko Oct 7, 2019

manuio Oct 8, 2019

manuio Oct 8, 2019

manuio Oct 8, 2019

drasko Oct 9, 2019

drasko Oct 9, 2019

drasko Oct 9, 2019

anovakovic01 Oct 10, 2019

anovakovic01 Oct 10, 2019

mteodor Oct 10, 2019

drasko Oct 11, 2019

drasko Oct 11, 2019

manuio left a comment

anovakovic01 left a comment

manuio left a comment

		@@ -51,6 +77,13 @@ type Service interface {

		// Get authenticated user info for the given token.

		}

		func (svc usersService) GenerateResetToken(ctx context.Context, email, host string) error {

		@@ -0,0 +1,155 @@
		//Package token provides password recovery token generation with TTL
		//Token is sent by email to user as part of recovery URL

MF-532 - Password reset #873

MF-532 - Password reset #873

Conversation

mteodor commented Sep 30, 2019 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to?

codecov-io commented Oct 4, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mteodor Oct 8, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manuio left a comment

Choose a reason for hiding this comment

anovakovic01 left a comment

Choose a reason for hiding this comment

manuio left a comment

Choose a reason for hiding this comment

mteodor commented Sep 30, 2019 •

edited

Loading

codecov-io commented Oct 4, 2019 •

edited

Loading

mteodor Oct 8, 2019 •

edited

Loading