Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix provision tool connect error handling #879

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

dborovcanin
Copy link
Collaborator

Signed-off-by: Dušan Borovčanin dusan.borovcanin@mainflux.com

What does this do?

This pull request adds error handling for connect errors.
Remove unused params from MQTT bench client.

List any changes that modify/break current functionality

There are no such changes.

Have you included tests for your changes?

No.

Did you document any new/modified functionality?

No.

@dborovcanin dborovcanin requested a review from a team as a code owner October 8, 2019 11:49
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #879 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files          74       74           
  Lines        4879     4879           
=======================================
  Hits         4127     4127           
  Misses        511      511           
  Partials      241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d939e...c87a7d8. Read the comment docs.

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tools/provision/provision.go Show resolved Hide resolved
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 23b421b into absmach:master Oct 8, 2019
@dborovcanin dborovcanin deleted the update/provision branch December 18, 2019 10:35
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants