NOISSUE - Switch to grpcbox for VerneMQ #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #914 +/- ##
==========================================
+ Coverage 83.57% 83.61% +0.03%
==========================================
Files 75 75
Lines 5357 5357
==========================================
+ Hits 4477 4479 +2
+ Misses 613 611 -2
Partials 267 267
Continue to review full report at Codecov.
|
dborovcanin
previously approved these changes
Oct 29, 2019
Use grpcbox as a gRPC client library, because it is much better maintained. Shows good performance and generation of protobuf files is simple and automatic. Signed-off-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Switch to grpcbox Use grpcbox as a gRPC client library, because it is much better maintained. Shows good performance and generation of protobuf files is simple and automatic. Signed-off-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com> * Fix typo Signed-off-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use grpcbox as a gRPC client library, because
it is much better maintained.
Shows good performance and generation of protobuf
files is simple and automatic.
Signed-off-by: Drasko DRASKOVIC drasko.draskovic@gmail.com
Pull request title should be
MF-XXX - descriptionorNOISSUE - descriptionwhere XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Which issue(s) does this PR fix/relate to?
Put here
Resolves #XXXto auto-close the issue that your PR fixes (if such)List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes