Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Change channels to chs #918

Merged
merged 1 commit into from
Oct 29, 2019
Merged

NOISSUE - Change channels to chs #918

merged 1 commit into from
Oct 29, 2019

Conversation

nwneisen
Copy link
Contributor

What does this do?

Cleanup changes from #889

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

None

Have you included tests for your changes?

NA

Did you document any new/modified functionality?

NA

Notes

There are additional areas in the things folder that could be changed to use chs and ths. Independent variables should be changed to chs while structure parameters should be left as channels. Same goes for things.

Signed-off-by: nwneisen <nwneisen@gmail.com>
@nwneisen nwneisen requested a review from a team as a code owner October 29, 2019 17:32
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko
Copy link
Contributor

drasko commented Oct 29, 2019

@manuio you will like this one :)

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 426813c into absmach:master Oct 29, 2019
@nwneisen nwneisen deleted the NOISSUE-cleanup-variable-names branch October 29, 2019 18:19
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: nwneisen <nwneisen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants