Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix HTTP header for Things and Channels creation #939

Merged
merged 1 commit into from
Nov 7, 2019
Merged

NOISSUE - Fix HTTP header for Things and Channels creation #939

merged 1 commit into from
Nov 7, 2019

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Nov 7, 2019

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner November 7, 2019 11:34
@codecov-io
Copy link

Codecov Report

Merging #939 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          75       75           
  Lines        5244     5244           
=======================================
  Hits         4325     4325           
  Misses        659      659           
  Partials      260      260
Impacted Files Coverage Δ
things/api/things/http/responses.go 97.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfdcfe...052c00b. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 841b943 into absmach:master Nov 7, 2019
@manuio manuio deleted the things branch November 7, 2019 12:57
manuio added a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants