Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Add missing user service tests #945

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

mteodor
Copy link
Contributor

@mteodor mteodor commented Nov 9, 2019

Signed-off-by: Mirko Teodorovic mirko.teodorovic@gmail.com

What does this do?

add missing user service tests

Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
@mteodor mteodor requested a review from a team as a code owner November 9, 2019 13:41
@codecov-io
Copy link

Codecov Report

Merging #945 into master will increase coverage by 1.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #945      +/-   ##
==========================================
+ Coverage   82.43%   83.65%   +1.22%     
==========================================
  Files          75       75              
  Lines        5244     5244              
==========================================
+ Hits         4323     4387      +64     
+ Misses        661      590      -71     
- Partials      260      267       +7
Impacted Files Coverage Δ
users/service.go 84.61% <100%> (+58.97%) ⬆️
users/api/http/transport.go 80.85% <0%> (+2.83%) ⬆️
users/api/http/requests.go 60% <0%> (+6.66%) ⬆️
users/api/http/endpoint.go 82.6% <0%> (+8.69%) ⬆️
users/api/http/responses.go 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841b943...ba321d6. Read the comment docs.

@drasko drasko changed the title NOISSUE - add missing user service tests NOISSUE - Add missing user service tests Nov 10, 2019
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit e735e5c into absmach:master Nov 10, 2019
@mteodor mteodor deleted the add-users-test branch September 22, 2020 10:37
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Mirko Teodorovic <mirko.teodorovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants