MF-898 - Change thing's service to use bulk connect #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
manuio
suggested changes
Nov 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
=========================================
Coverage ? 83.65%
=========================================
Files ? 75
Lines ? 5255
Branches ? 0
=========================================
Hits ? 4396
Misses ? 590
Partials ? 269
Continue to review full report at Codecov.
|
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
manuio
suggested changes
Nov 11, 2019
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Change thing's service to use bulk connect Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Move owner check outside of loop Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Change invalid user to unauthorized access error Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Neisen nwneisen@gmail.com
What does this do?
Add bulk connect to the thing's service.
Which issue(s) does this PR fix/relate to?
Related to #898.
List any changes that modify/break current functionality
Things can now be connected to a channel at a service level.
Have you included tests for your changes?
Tests for single creation modified as needed.
Did you document any new/modified functionality?
Documentation will be modified in the final PR when the user's endpoint is changed.
Notes