NOISSUE - Fix opcua-adapter events decode #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 75 75
Lines 5307 5307
=======================================
Hits 4445 4445
Misses 587 587
Partials 275 275Continue to review full report at Codecov.
|
nmarcetic
reviewed
Nov 15, 2019
opcua/gopcua/sub.go
Outdated
| @@ -53,16 +53,16 @@ func (b client) Subscribe(cfg opcua.Config) error { | |||
| } | |||
|
|
|||
| c := opcuaGopcua.NewClient(ep.EndpointURL, opts...) | |||
| if errC := c.Connect(b.ctx); err != nil { | |||
| b.logger.Error(errC.Error()) | |||
| if errc := c.Connect(b.ctx); errc != nil { | |||
There was a problem hiding this comment.
Why not just follow err propagation? Why new var errc and errs?
There was a problem hiding this comment.
Indeed, err is a special var in Go that can be re-assigned with :=
opcua/redis/streams.go
Outdated
| @@ -89,12 +93,12 @@ func (es eventStore) Subscribe(subject string) error { | |||
| } | |||
| err = es.handleCreateThing(cte) | |||
| case thingUpdate: | |||
| ute, derr := decodeUpdateThing(event) | |||
| ute, derr := decodeCreateThing(event) | |||
nmarcetic
previously approved these changes
Nov 15, 2019
drasko
requested changes
Nov 19, 2019
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
dborovcanin
reviewed
Nov 22, 2019
opcua/gopcua/sub.go
Outdated
| if errC := c.Connect(b.ctx); err != nil { | ||
| b.logger.Error(errC.Error()) | ||
| if err := c.Connect(b.ctx); err != nil { | ||
| return fmt.Errorf("Failed to connect: %s", err) |
There was a problem hiding this comment.
You can use our errors package here, something like: errors.Wrap(ErrFailedConn, err).
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
drasko
dismissed
their stale review
Dismissing until Dusan's remarks are not taken into account.
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
nmarcetic
approved these changes
Nov 25, 2019
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Enable multi OPC-UA Subscriptions Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * NOISSUE - Fix opcua-adapter events decode Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use a config file to subscribe to multiple nodes Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add subscription config file Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Use Mainflux errors package Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an existing event processing implementation, whenever the processor receives a new event with some unexpected format it will break. This implementation should be able to handle unexpected metadata formats in a better way.