Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Remove Elm UI #953

Merged
merged 1 commit into from
Nov 19, 2019
Merged

NOISSUE - Remove Elm UI #953

merged 1 commit into from
Nov 19, 2019

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Nov 18, 2019

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner November 18, 2019 13:45
@codecov-io
Copy link

Codecov Report

Merging #953 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   83.75%   83.75%           
=======================================
  Files          75       75           
  Lines        5288     5288           
=======================================
  Hits         4429     4429           
  Misses        590      590           
  Partials      269      269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e35cbe...d2b111d. Read the comment docs.

@blokovi
Copy link
Contributor

blokovi commented Nov 18, 2019

You can remove MF_UI_PORT from .env file also

@blokovi
Copy link
Contributor

blokovi commented Nov 18, 2019

You can remove MF_UI_PORT from .env file also

Or maybe not because it's in nginx configuration

@manuio
Copy link
Contributor Author

manuio commented Nov 18, 2019

@chombium
Copy link
Collaborator

@manuio @blokovi we should remove the MF_UI_PORT and when someone wants to deploy the ui as well, he/she can use the docker-compose overriding as described here. We should add a new docker-compose file with the ui comfig in a docker-compose.yml file.

As adding the configuration for the ui is out of scope for this issue I suggest that we merge this and open another issue

@drasko
Copy link
Contributor

drasko commented Nov 19, 2019

@chombium UI will not be removed, but basic Elm UI replaced with new one that @manuio made with ngx-admin and will be placed here: https://github.com/mainflux/ui

@drasko
Copy link
Contributor

drasko commented Nov 19, 2019

For the reference, Elm UI has been moved here.

@drasko drasko merged commit ac3ff52 into absmach:master Nov 19, 2019
@chombium
Copy link
Collaborator

@drasko thanks for the clarification.
I saw that the Elm UI has been moved as it was previously discussed, but I didn't know that there is a new UI.

@manuio manuio deleted the ui branch November 19, 2019 09:46
manuio added a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants