-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Remove Elm UI #953
Conversation
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #953 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 75 75
Lines 5288 5288
=======================================
Hits 4429 4429
Misses 590 590
Partials 269 269 Continue to review full report at Codecov.
|
You can remove |
Or maybe not because it's in nginx configuration |
@blokovi yes, you need it here: https://github.com/mainflux/mainflux/blob/master/docker/docker-compose.yml#L234 |
@manuio @blokovi we should remove the As adding the configuration for the ui is out of scope for this issue I suggest that we merge this and open another issue |
@chombium UI will not be removed, but basic Elm UI replaced with new one that @manuio made with ngx-admin and will be placed here: https://github.com/mainflux/ui |
For the reference, Elm UI has been moved here. |
@drasko thanks for the clarification. |
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com