MF-898 - Add bulk connect to CLI and SDK #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 84% 83.66% -0.34%
==========================================
Files 75 75
Lines 5382 5308 -74
==========================================
- Hits 4521 4441 -80
- Misses 586 595 +9
+ Partials 275 272 -3
Continue to review full report at Codecov.
|
manuio
reviewed
Nov 19, 2019
manuio
suggested changes
Nov 19, 2019
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
manuio
suggested changes
Nov 19, 2019
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
|
I'm not sure why the coverage dropped after changing to consts. It's not giving me much information to go off of. |
|
Great contribution again @nwneisen, approved. I'll let other take a look and merge tomorrow. |
nmarcetic
reviewed
Nov 20, 2019
Signed-off-by: Nick Neisen <nwneisen@gmail.com>
dborovcanin
approved these changes
Nov 21, 2019
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add bulk connect to CLI and SDK Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Add test for bulk connect Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Update docs Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Add file example Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Add JSON example to CLI docs Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Change some value datatypes back Signed-off-by: Nick Neisen <nwneisen@gmail.com> * Use constants for file extensions Signed-off-by: Nick Neisen <nwneisen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds bulk connect functionality to the SDK and CLI
Which issue(s) does this PR fix/relate to?
Resolves #898
List any changes that modify/break current functionality
Multiple connections can now be created using the SDK or CLI
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
Yes
Notes