NOISSUE - Fix Update User #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #959 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 75 75
Lines 5288 5288
=======================================
Hits 4429 4429
Misses 590 590
Partials 269 269
Continue to review full report at Codecov.
|
mteodor
reviewed
Nov 20, 2019
users/service_test.go
Outdated
| func TestUpdateUser(t *testing.T) { | ||
| svc := newService() | ||
| svc.Register(context.Background(), user) | ||
| key, _ := svc.Login(context.Background(), user) | ||
| nonExistingKey, _ := svc.Login(context.Background(), nonExistingUser) |
There was a problem hiding this comment.
you cant use login here, you havent registered user, this will fail
to create key
j := jwt.New("secret")
key, _ := j.TemporaryKey(user.Email)
There was a problem hiding this comment.
@mteodor I agree with you but let's just remove this test. No need to create a valid token for this test.
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
mteodor
approved these changes
Nov 20, 2019
dborovcanin
approved these changes
Nov 20, 2019
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Fix Update User Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Rm duplicated test Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix typo Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com