NOISSUE - Support multiple types values in opcua-adapter #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 83.75% 83.75%
=======================================
Files 75 75
Lines 5305 5305
=======================================
Hits 4443 4443
Misses 587 587
Partials 275 275Continue to review full report at Codecov.
|
nmarcetic
approved these changes
Nov 28, 2019
drasko
reviewed
Nov 28, 2019
| endpoints, err := opcuaGopcua.GetEndpoints(cfg.ServerURI) | ||
| if err != nil { | ||
| return errors.Wrap(errFailedFetchEndpoint, err) | ||
| opts := []opcuaGopcua.Option{ |
There was a problem hiding this comment.
I let you decide, but maybe shorten the naming. Something like gopc or (gopcua) and gua?
There was a problem hiding this comment.
I'll keep this in mind for the next PR
drasko
approved these changes
Nov 28, 2019
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com