Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix Redis event naming #996

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

drasko
Copy link
Contributor

@drasko drasko commented Jan 8, 2020

Signed-off-by: Drasko DRASKOVIC drasko.draskovic@gmail.com

Pull request title should be MF-XXX - description or NOISSUE - description where XXX is ID of issue that this PR relate to.
Please review the CONTRIBUTING.md file for detailed contributing guidelines.

What does this do?

Which issue(s) does this PR fix/relate to?

Put here Resolves #XXX to auto-close the issue that your PR fixes (if such)

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Signed-off-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
@drasko drasko requested a review from a team as a code owner January 8, 2020 16:39
@codecov-io
Copy link

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          87       87           
  Lines        5850     5850           
=======================================
  Hits         4841     4841           
  Misses        723      723           
  Partials      286      286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42f209...990838b. Read the comment docs.

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blokovi blokovi merged commit 5834d36 into absmach:master Jan 9, 2020
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Drasko DRASKOVIC <drasko.draskovic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants