Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fix Model Button in Favor of Multiple #519

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

989onan
Copy link
Contributor

@989onan 989onan commented Jul 18, 2022

To fix confusion people have in the discord on "Why isn't this """fixing""" my model?" maybe a better term for this button would be standardize. This is because standardizing is what it does. It makes the model bones have standard names (The ones cats uses) and it makes everything work for VRChat.

Sure it does "fix" the model, but this can be taken in the wrong context (And has on almost every occasion that someone complained about the button) because it doesn't "fix" any issue thrown, which is what makes people think it's a """magic button""" because they think it can fix anything thrown at it.

I hope this fixes the problem of people misinterpreting it's usage.

name open to changes but a name other than "Fix Model" that is reflective of it's actual function and would help sort out confusion would be much appreciated

Thanks!

To fix confusion people have in the discord on "Why isn't this """fixing""" my model?" maybe a better term for this button would be standardize. This is because standardizing is what it does. It makes the model bones have standard names (The ones cats uses) and it makes everything work for VRChat.

Sure it does "fix" the model, but this can be taken in the wrong context (And has on almost every occasion that someone complained about the button) because it doesn't "fix" any issue thrown, which is what makes people think it's a """magic button""" because they think it can fix anything thrown at it.

I hope this fixes the problem of people misinterpreting it's usage.

**name open to changes** but a name other than "Fix Model" that is reflective of it's actual function and would help sort out confusion would be much appreciated

Thanks!
@989onan
Copy link
Contributor Author

989onan commented Sep 22, 2022

Update, I added @Mysteryem 's code from #435 into this commit too. This is because I added a very beta thing prone to errors where the buttons for Fix Model are now separate sub task buttons.

For anyone linked this comment on this commit as an explanation for the changes, the information below is the full explanation of the change, and why.

This is to force users to use the fix model functions as tools rather than a magic button. This fixes the many issues posted on the discord concerning fix model and the many tutorials and guides asking people to use cats just for the fix model because it's """""Magical""""".
Trying to wrap everything under one button as a fix all is a disaster, and separating the functions will ultimately fix the issues with dealing with 100+ exceptions and branches in the code that has turned spaghetti at this point. I have made the mistake of trying to add onto the code, and it's becoming GTA online's source code at this point. (pile crap on top of the previous, don't test extensively, and ignore)

Rather than putting things under fix model, making them separate buttons and functions allows users easier access to the things they need to do, and fix ignorance of people pressing the button because a tutorial told them to.

I left the old code for fix model in a state where I cannibalized it for code parts. If there is anything I missed that can be put into a new button, then please do! I did leave a clear comment to not use it again, since it causes more issues than it solves for a majority of users.

@989onan 989onan changed the title Change "Fix Model" To "Standardize Model" Remove Fix Model Button in Favor of Multiple Sep 22, 2022
@hazre
Copy link

hazre commented Sep 26, 2022

+1

This is definitely needed, "fix model" button breaks more avatars than it fixes because most users don't understand what it actually does behind the scenes.

On a unrelated note, this is especially true when content creators enforce the use of the button after every single change. This leads to mass misinformation and causes a lot of avatars to break because new users to blender just follow these tutorials on YouTube.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants