Adding "seq" kwargs to events, this fixes #4 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://poloniex.com/support/api/ """ The dictionary portion of each market message ("kwargs" in the Node.js example) will contain a sequence number with the key "seq". In order to keep your order book consistent, you will need to ensure that messages are applied in the order of their sequence numbers, even if they arrive out of order. In some markets, if there is no update for more than 1 second, a heartbeat message consisting of an empty argument list and the latest sequence number will be sent. These will go out once per second, but if there is no update for more than 60 seconds, the heartbeat interval will be reduced to 8 seconds until the next update. Several order book and trade history updates will often arrive in a single message. Be sure to loop through the entire array, otherwise you will miss some updates. """
Pulled from var currencyPairArray on https://poloniex.com/exchange Current as of Sun May 7 07:11:23 UTC 2017
andrewshvv
reviewed
May 7, 2017
| @@ -47,9 +47,10 @@ def ticker_wrapper(handler): | |||
|
|
|||
|
|
|||
| def trades_wrapper(topic, handler): | |||
| async def decorator(data): | |||
There was a problem hiding this comment.
@clayrichardson Will other handlers work in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another option would be to not overload the handler, but that requires more modification.