Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storybook): test headers by placing cursor - #14 #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sanketshevkar
Copy link
Member

Signed-off-by: Sanket Shevkar shevkar.sanket@gmail.com

Changes

  • Had some issues with my fork and local repository. So I am creating a new PR after creating a new fork. Added tests for all 6 headers.

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: Sanket Shevkar <shevkar.sanket@gmail.com>
@sanketshevkar
Copy link
Member Author

@Michael-Grover @irmerk I've updated the changes you suggested in #311. I am closing #311. Sorry for the inconvenience.

Copy link

@Michael-Grover Michael-Grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I also requested a review from @irmerk or @DianaLease

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few of the tests are failing in the CI. Can you please take a look?

Screen Shot 2021-06-02 at 5 29 01 PM

@sanketshevkar
Copy link
Member Author

Looks like a few of the tests are failing in the CI. Can you please take a look?

Screen Shot 2021-06-02 at 5 29 01 PM

Individually tested, all tests are working fine, but when all are run together they sometimes are not able load and find the components needed for testing. I'll find a way to optimise this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants