Mypy: removed type ignore at Annotation

acdh-oeaw · Feb 8, 2024 · 68ce756 · 68ce756
1 parent 6e81ac1
commit 68ce756
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/openatlas/database/annotation.py b/openatlas/database/annotation.py
@@ -1,12 +1,12 @@
-from typing import Any, Optional
+from typing import Any
 
 from flask import g
 
 
 class AnnotationImage:
 
     @staticmethod
-    def get_by_id(id_: int) -> Optional[dict[str, Any]]:
+    def get_by_id(id_: int) -> dict[str, Any]:
         g.cursor.execute(
             """
             SELECT
@@ -21,7 +21,7 @@ def get_by_id(id_: int) -> Optional[dict[str, Any]]:
             WHERE id =  %(id)s;
             """,
             {'id': id_})
-        return dict(g.cursor.fetchone()) if g.cursor.rowcount else None
+        return dict(g.cursor.fetchone()) if g.cursor.rowcount else {}
 
     @staticmethod
     def get_by_file(image_id: int) -> list[dict[str, Any]]:

diff --git a/openatlas/models/annotation.py b/openatlas/models/annotation.py
@@ -32,7 +32,7 @@ def delete(self) -> None:
 
     @staticmethod
     def get_by_id(id_: int) -> Annotation:
-        return Annotation(Db.get_by_id(id_))  # type: ignore
+        return Annotation(Db.get_by_id(id_))
 
     @staticmethod
     def get_by_file(image_id: int) -> list[Annotation]: