Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hearing - Fix deafness reducing when game is paused #10039

Merged
merged 2 commits into from
May 29, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Deafness would be diminished when the game was paused.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label May 28, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone May 28, 2024
@LinkIsGrim
Copy link
Contributor

LinkIsGrim commented May 28, 2024

isGameFocused returns false when alt-tabbing in Multiplayer, isGamePaused does not. I'm guessing this was taken into account?

@johnb432
Copy link
Contributor Author

isGameFocused returns true when alt-tabbing in Multiplayer, isGamePaused does not. I'm guessing this was taken into account?

Imo regardless of isGameFocused's weird behaviour, it shouldn't be used in this case. If the game is running (simulation to be specific), then the sound loop should be simulated, otherwise it should be paused, like the simulation.
I took it into account, but I have no idea if the original authors did.

@LinkIsGrim
Copy link
Contributor

Derp. Switched true & false when typing. Either way, makes sense to me.

@LinkIsGrim LinkIsGrim enabled auto-merge (squash) May 29, 2024 18:54
@LinkIsGrim LinkIsGrim merged commit 98f4b51 into master May 29, 2024
3 of 5 checks passed
@johnb432 johnb432 deleted the hearing-fix-pause-game branch May 29, 2024 18:56
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants