Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Add addPlayerEH for adding EHs to ace_player #10056

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Jun 5, 2024

from #9839

helper func to add direct EHs to ace_player

pattern used in:
ace_ui_fnc_handlePlayerChanged
hearing\postInit
adv fatigue

but I don't see any reason to change them to use this

@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Jun 5, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone Jun 5, 2024
@johnb432
Copy link
Contributor

johnb432 commented Jun 6, 2024

but I don't see any reason to change them to use this

Personally I'd like to see them updated, but I'll do it in another PR.

@PabstMirror
Copy link
Contributor Author

I moved UI over,
adv fatigue uses player changed EH to do other stuff like copy vars around so it really doesn't need it
hearing has open prs

@PabstMirror PabstMirror merged commit 97bc371 into master Jun 9, 2024
5 checks passed
@PabstMirror PabstMirror deleted the addPlayerEH branch June 9, 2024 23:20
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Common - Add `addPlayerEH` for adding EHs to ace_player

* Update fnc_addPlayerEH.sqf

* convert ui to use new func
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants