Compat CUP Units - Goggles Compatibility #10065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
added
kind/enhancement
PabstMirror
approved these changes
Jun 12, 2024
rautamiekka
reviewed
Jun 12, 2024
| ace_tintAmount = 8; | ||
| }; | ||
|
|
||
| // Shades - Clear |
There was a problem hiding this comment.
How come no inheritance is used for the diff variants ? These shades being a good place to, for ex, which would decrease space wasting.
There was a problem hiding this comment.
Ask CUP, it is how they encoded it.
There was a problem hiding this comment.
This tinting and stuff is only related to ACE, that's why.
There was a problem hiding this comment.
But majority of them inherit from None and we can't change None without side effects.
jonpas
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: