Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogtags - Stop throwing error when trying to take dog tags #10103

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jul 2, 2024

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the ignore-changelog Release Notes: Excluded label Jul 2, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jul 2, 2024
@PabstMirror
Copy link
Contributor

this is my bad, I guess it doesn't work because it's scope=0?

@johnb432
Copy link
Contributor Author

johnb432 commented Jul 2, 2024

this is my bad, I guess it doesn't work because it's scope=0?

I tested it, but for only when it returned false, which didn't make it throw the error.
Yea, it's because it's scope = 0

@johnb432 johnb432 merged commit 516eb48 into master Jul 2, 2024
5 checks passed
@johnb432 johnb432 deleted the dogtags-fix-condition branch July 2, 2024 18:16
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants