Common - Add ace_common_fnc_switchAttachmentMode
#10135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
approved these changes
Jul 21, 2024
|
Imo this should be in CBA. https://github.com/acemod/ACE3/blob/master/addons/interaction/functions/fnc_switchWeaponAttachment.sqf should probably be updated with CBA events. Even better would be to replace it with this function (or if implemented in CBA). |
johnb432
approved these changes
Jul 25, 2024
johnb432
reviewed
Jul 25, 2024
johnb432
reviewed
Jul 25, 2024
johnb432
reviewed
Jul 25, 2024
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
PabstMirror
added
kind/enhancement
blake8090
pushed a commit
to blake8090/ACE3
that referenced
this pull request
Aug 18, 2024
* Common - Add `ace_common_fnc_switchAttachmentMode` * Update addons/common/functions/fnc_switchAttachmentMode.sqf * Update addons/common/functions/fnc_switchAttachmentMode.sqf * playSound only for ACE_player Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> --------- Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com> Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe needed for #10119 and #8154