Arsenal - Add ace_arsenal_fnc_saveLoadout as API to save loadouts

[DartRuffian]

When merged this pull request will:

• Add a public function to save a given loadout

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[DartRuffian]

fnc_saveLoadout should have some more verification to make sure improper loadouts are not saved, but not entirely sure how that should be implemented.

I have also left the documentation (currently) unedited because I wasn't sure how that should be organized.

PR title is also open-ended in-case other functions come up.

[LinkIsGrim]

fnc_saveLoadout should have some more verification to make sure improper loadouts are not saved, but not entirely sure how that should be implemented.

arma-rs (#9015) might be able to handle that?

[DartRuffian]

fnc_saveLoadout should have some more verification to make sure improper loadouts are not saved, but not entirely sure how that should be implemented.

arma-rs (#9015) might be able to handle that?

Works for me.
Just wasn't sure if verification should be handled here, since it's also handled when actually opening the loadouts menu

[DartRuffian]

Should there be fnc_deleteLoadout and/or fnc_getLoadout at all?
Seems unnecessary as it's pretty easy to do by just pulling the variable and doing X.

If there's not a desire for other public functions, and verification is already handled, then this PR should be good then

[DartRuffian]

Maybe the second param could also take a unit, and would use the unit's loadout if passed?

Was just something I thought of while at work, figured it might make saving loadouts a tiny bit easier for persistent campaigns or something similar.

["Loadout", [...]] call ace_arsenal_fnc_saveLoadout;

["Loadout", player, true] call ace_arsenal_fnc_saveLoadout;

[rautamiekka]

Maybe the second param could also take a unit, and would use the unit's loadout if passed?

Was just something I thought of while at work, figured it might make saving loadouts a tiny bit easier for persistent campaigns or something similar.

["Loadout", [...]] call ace_arsenal_fnc_saveLoadout;

["Loadout", player, true] call ace_arsenal_fnc_saveLoadout;

100% agree.

[johnb432]

Was just something I thought of while at work, figured it might make saving loadouts a tiny bit easier for persistent campaigns or something similar.

Imo not worth the extra code inside the functions, you can more easily add player call CBA_fnc_getLoadout to this function's call. It would be yet another thing to have to maintain for BWC, in case we ever want to change something in the future.

[DartRuffian]

Fair point, should be good for review then.

[johnb432]

Documentation still required.

[DartRuffian]

Was waiting to see if anything else might pop up. I'll write it after work (~7 hours)

[DartRuffian]

Added a scripting example, I don't think an entire section is needed for a relatively simple function.

[rautamiekka]

Now is too late, but set (and some other commands) supports using -1 to indicate the end of an array since 'Arma 3 v2.12', so, unless there's something I dunno, it shouldn't be necessary to do a separate pushBack for -1.

[DartRuffian]

-1 is not an index in this case, findIf returns -1 if the given item is not found in the array.