-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frag - Add public blacklist interface #10163
Frag - Add public blacklist interface #10163
Conversation
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
quick testing shows a whole 600ns increase in Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
…shooters Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
* The function takes three arguments, although the last two are optional. The first argument is the ammo class name to ignore, while the second and third are | ||
* whether the class should be blacklisted from producing fragments and spall, respectively. Once an ammo has been blacklisted, it can be removed from the blacklist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be placed in the "arguments" section.
The two sentences here are useless imo, last sentence is useful info ('Once an...').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always felt confused and under explained when reading the ACE documentation, but that's probably a me thing. I'll move relevant information to the arguments/example and delete the rest. Let me know if that's still too much
Naming is a bit weird to me: add implies you can only add to the blacklist, not remove from it. set would be more appropriate I think That being said, it's trivial. Anyone touching this is going to read the docs, and if a class is being added then removed from the blacklist, there's some bad decisions being made somewhere. |
Sure, would you say |
|
Missed some semicolons on function return values |
This PR is based on PR #10157 and requires it to be merged.
When merged this pull request will:
Feedback on the wording for the function descriptions is most welcome (and the code itself)!
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}
.