Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Feedback - Add parameters to fnc_playInjuredSound #10175

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Medical Feedback - Add parameters to fnc_playInjuredSound #10175

merged 3 commits into from
Aug 9, 2024

Conversation

tuntematonjr
Copy link
Contributor

When merged this pull request will:

  • Add parameters to allow changing distances for sounds for each severity.
  • Add parameter to allow unconscious units to do sounds.
  • This does not impact the default functionality.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@tuntematonjr
Additional parameters
5f22bfd 
- added parameters to allow changing distances for sounds for each severity.
- added parameter to allow unconscious units to do sounds.
@tuntematonjr
fix conditio
39b552c
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Aug 8, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 8, 2024
johnb432
johnb432 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty to adjust the header to our current formatting style (header was outdated prior to this PR and given the opportunity, I figured I would address it now).

@PabstMirror PabstMirror merged commit b2a3fac into acemod:master Aug 9, 2024
5 checks passed
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@tuntematonjr @johnb432 @blake8090
Medical Feedback - Add parameters to fnc_playInjuredSound (acemod#10175)
b50ddcf 
* Additional parameters

- added parameters to allow changing distances for sounds for each severity.
- added parameter to allow unconscious units to do sounds.

* fix conditio

* Updated header formatting + minor tweaks

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tuntematonjr @PabstMirror @johnb432