Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookoff - Use triggerAmmo instead of setDamage #10185

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • In Cookoff - Mini-Rewrite #9758, I removed the ability for magazines inside a vehicle's inventory to spawn projectiles (see Cookoff - Mini-Rewrite #9758 (comment)). I think having none is too extreme, but I agree with not all: a vehicle packed to the brim with explosives should spawn some of them in. Even if they aren't explosives, magazines should have a chance to spawn in projectiles. For now it's 50% for each magazine, if people feel it's too high it can be lowered.
  • Minor optimisations.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** ignore-changelog Release Notes: Excluded labels Aug 10, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 10, 2024
@johnb432 johnb432 changed the title Cookoff - Use triggerAmmo Cookoff - Use triggerAmmo instead of setDamage Aug 10, 2024
@LinkIsGrim LinkIsGrim merged commit 43d42c8 into master Aug 11, 2024
5 checks passed
@LinkIsGrim LinkIsGrim deleted the cookoff-use-triggerAmmo branch August 11, 2024 23:31
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants