SPE Compat - Add interaction anims to SPE vehicles #10226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Aug 18, 2024
| class spare_fuel_hide_source: spare_fuel_hide_source { | ||
| positions[] = {{0.8, 1.25, -0.8}, {-0.8, 1.25, -0.8}, {0.8, 2.95, -0.8}, {-0.8, 2.95, -0.8}, {0.8, -1, -0.3}, {-0.8, -1, -0.3}}; | ||
| items[] = { // 32x | ||
| "Land_CanisterFuel_F", "Land_CanisterFuel_F", "Land_CanisterFuel_F", "Land_CanisterFuel_F", |
There was a problem hiding this comment.
I'm worried about physx collisions,
we don't have to be exact on the number imho
There was a problem hiding this comment.
EFUNC(common,findUnloadPosition) handles finding an empty space. I'll test this more, but I don't think there's much of a reason to be worried.
There was a problem hiding this comment.
ace_interaction_fnc_initAnimActions:
// If 1 object was spawned in, consider it a success
also code will try to spawn as many as it can but won't fail if it can't find room for all of them
There was a problem hiding this comment.
Yea, I changed it to work like that, because I'm not sure what to consider a success otherwise.
PabstMirror
approved these changes
Aug 18, 2024
johnb432
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.