Common - Add ace_common_fnc_addExplosionEventHandler

[PabstMirror]

Add an explosion event handler to common so multiple systems can hook into the same event

• Local event
• ace_hearing take the local event and re-broadcasts
  (might be worthwhile to only broadcast to close-distance units?)

[lambdatiger]

Ignore that last comment, I was mistaken.

I am un-mistaken, there's some hurdles with using local on projectiles that I couldn't overcome using init event handlers on ace_frag and was planning on addressing with Arma 3 v2.18's getShotInfo, specifically the isReal value.

fuckingHellFoundIt.mp4

[PabstMirror]

e.g. 12Rnd_120mm_HE_shells_Tracer_Red
seems like shots that are tracers and explosive will show as local to all units (or all units in visible range?)
and produce the explode event multiple times

This PR can wait, but it's really just a wrapper for changes from #10002 so we'll have to figure something out for hearing
or we'll have problems with n^2 ear ringing

[PabstMirror]

I see only 2 solutions right now

• we put this (and the hearing/explosion part) on hold until 2.18
• we have this hook into firedEH just like the frag pr is doing (and then revert back after 2.18?)

[johnb432]

* we have this hook into firedEH just like the frag pr is doing (and then revert back after 2.18?)

I don't think fired would work for things such as mines and explosives, but I haven't tested and can't confirm it at all.

Since some projectiles seem to be local to all units, wouldn't they be objNull on different clients, meaning we could just filter out isNull and have it work? It's not great from a network point of view, but imo it beats using the fired EH. Testing suggests the above would work.

[johnb432]

Even better: Dedmen told me that local objects return a netID of 0:0. I tested it with projectiles and it seems to also be the case.

[PabstMirror]

If "ProjectileCreated" is added during preInit it will pickup mission placed explosives
but we won't know if we want it until after settings are init...

maybe something to think about in the future

[johnb432]

If "ProjectileCreated" is added during preInit it will pickup mission placed explosives but we won't know if we want it until after settings are init...

maybe something to think about in the future

if (!EGVAR(common,settingsInitFinished)) exitWith {
    EGVAR(common,runAtSettingsInitialized) pushBack [{}, _this];
};

?

[PabstMirror]

seems to work correctly in mp with a pre-placed satchel

[PabstMirror]

I can't test mp on dev branch so we won't really know until the RC is out, but sounds like it will work as expected
posting comments from #dev_rc_branch comments for reference

johnb43 — 08/28/2024 8:53 AM
Do we have a method of being able to tell if an object or projectile exists on the current machine only?
I'd like to avoid sending references to objects/projectiles don't exist globally over the network.
If we don't have methods currently, could we get them returned in getEntityInfo/getShotInfo? I can make a ticket if wanted.
Dedmen (ง •̀_•́)ง — 08/28/2024 9:01 AM
NetID
0:0 for locals
johnb43 — 08/28/2024 9:07 AM
Do you know if that works for projectiles too?
Dedmen (ง •̀_•́)ง — 08/28/2024 9:09 AM
Uff
Maybe not. But I'd expect shot info to have the local/virtual/fake flag
Yeah the isReal flag
It's false for remote projectiles.
Don't know if there would be a local projectile that's also not real
johnb43 — 08/28/2024 9:13 AM
It looks like netID returns 0:0 for local projectiles
But we might switch over to getShotInfo isReal when 2.18 comes out
Thanks!