Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastroping - Fix FRIES not working after vehicle respawn #10268

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Aug 27, 2024

When merged this pull request will:

  • Fix Problems with using ACE FRIES with BI respawn  #6862. The issue stems from the fact that we reset the variable QGVAR(FRIES) to nil when the vehicle is killed (or deleted, but not relevant here). It is then copied to the new object, as it still shows up in allVariables (which BI uses to move all variables from one object to another).
  • Very minor cleanup.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Aug 27, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 27, 2024
if !(_vehicle getVariable [QGVAR(addFRIESOnRespawn), false]) exitWith {};

_vehicle call FUNC(equipFRIES);
}] call BIS_fnc_addScriptedEventHandler;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hate it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I aim to please :)

@LinkIsGrim LinkIsGrim merged commit 96700e8 into master Aug 27, 2024
4 checks passed
@LinkIsGrim LinkIsGrim deleted the fastroping-fix-respawn-module-messing-up-FRIES branch August 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with using ACE FRIES with BI respawn
2 participants