Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSW - Improve "disableWeaponAssembly" status effect usage #10273

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Turn off vanilla assembly for placed tripods and assembled CSWs, so that FUNC(initVehicle) can handle enabling/disabling vanilla assembly when the QGVAR(assemblyMode) is set on the vehicle.
  • Only set the status effect where the gunner's turret is local. Until now, every machine set a status effect that has a global effect, which is useless.
  • Removed the execNextFrame in FUNC(initVehicle), because it runs 1 second after a vehicle has been created, so no need for the frame of delay.
  • Optimised FUNC(staticWeaponInit_unloadExtraMags) slightly (from CSW - Rework settings #9901).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Aug 29, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Aug 29, 2024
@johnb432 johnb432 merged commit c80d623 into master Aug 30, 2024
4 checks passed
@johnb432 johnb432 deleted the csw-improve-disableweaponassembly branch August 30, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants