missile_hud - Move HUD feature from laser to new component
#10306
+628
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
approved these changes
Nov 22, 2024
rautamiekka
suggested changes
Nov 23, 2024
| if !(_elementArray isEqualTypeArray ["", "", []]) exitWith { TRACE_1("Invalid - Types not equal",_elementArray); false }; | ||
| _elementArray params ["_type", "_str", "_color"]; | ||
| if !(_type in ["TEXT", "ICON", "SPACER"]) exitWith { TRACE_1("Invalid - Element Type not supported",_type); false }; | ||
| private _success = if (_type != "SPACER") then { |
There was a problem hiding this comment.
Suggested change
| private _success = if (_type != "SPACER") then { | |
| private _success = if (_type isNotEqualTo "SPACER") then { |
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
lasertomissile_hudthe HUD for laser guided munitions lived in
laserforever. This doesn't make any sense, as the HUD is meant to showcase missile information. A new API was made to be able to extend what is shown to the user, as well as move functionality fromlaserIt works in an immediate mode fashion. New elements are constructed each frame and added to the HUD. The elements which get generated are culled each time the HUD PFH gets rebuilt, so only relevant items are drawn. A mapping function exists to allow for pre-processing of any information needed
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.