Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common - Fix retrieving the version of an addon when searching for mismatches #10377

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Common - Fix retrieving the version of an addon when searching for mismatches #10377

merged 5 commits into from
Oct 25, 2024

Conversation

Timi007
Copy link
Contributor

@Timi007 Timi007 commented Oct 8, 2024

When merged this pull request will:

  • Fix retrieving the version of an addon when searching for version mismatches.
  • Keep the current logic of handling versions as floating point numbers.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

Does this match 3.17.1 behavior?

@johnb432
Copy link
Contributor

johnb432 commented Oct 9, 2024

Does this match 3.17.1 behavior?

No, it adds onto it. #9266 just moved that part of the code without modifying it.

@johnb432 johnb432 self-requested a review October 9, 2024 05:48
@Timi007
Copy link
Contributor Author

Timi007 commented Oct 9, 2024 •
edited
Loading

Mh, I noticed that my first case of just getting the number as a float is wrong compared to the other cases.

Example:
Client: version = 1.9
Server: version = 1.10 -> A3 gets 1.1
results in: Client (newer) > Server

Should we just ignore floating point version altogether?

@Timi007
Copy link
Contributor Author

Timi007 commented Oct 9, 2024

Does this match 3.17.1 behavior?

I don't know if BI changed the behavior of getText but getting the version now in A3 2.18 with this command results in nothing when a floating point number is assigned to version (typical with CBA/ACE structured addons). The default value of 0 applies on parsing errors. Therefore, all float versions are 0 and no mismatch is detected.

@PabstMirror
Copy link
Contributor

iirc they mentioned using a newer compiler that might have changed float->string conversions?

@johnb432
Copy link
Contributor

johnb432 commented Oct 12, 2024 •
edited
Loading

Example: Client: version = 1.9 Server: version = 1.10 -> A3 gets 1.1 results in: Client (newer) > Server

That's indeed less than ideal. I'm trying to come up with a better solution.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Oct 19, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Oct 19, 2024
@johnb432 johnb432 merged commit 56eaac9 into acemod:master Oct 25, 2024
3 checks passed
@Timi007 Timi007 deleted the fix_versioning branch October 25, 2024 16:49
LinkIsGrim pushed a commit that referenced this pull request Nov 2, 2024
@Timi007 @johnb432 @LinkIsGrim
Common - Fix retrieving the version of an addon when searching for mi…
c4ffa8c 
…smatches (#10377)

* Fix version retrieval

* Correct spelling

* Correct spelling 2

* Optimize

---------

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Timi007 @PabstMirror @johnb432