Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Add medication dosage support & improve overdose #10393

Merged
merged 60 commits into from
Nov 15, 2024

Conversation

Cplhardcore
Copy link
Contributor

When merged this pull request will:

  • Rework overdose slightly, for better handling with external mods with multiple dose levels for one kind of medication
  • splits overdose into its own function
  • adds the getAllMedicationCount function, which gets all medications in a unit and outputs them in an array of arrays containing the medication's name, the dose, and the effectiveness

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim self-assigned this Oct 11, 2024
Cplhardcore and others added 5 commits October 12, 2024 08:22
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
@LinkIsGrim
Copy link
Contributor

Don't worry about the failing pboProject build. Do worry about HEMTT warnings/errors though.

Cplhardcore and others added 2 commits October 23, 2024 01:07
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Copy link
Contributor

@johnb432 johnb432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, there no mention anywhere in the title or description about drugs getting CBA settings for their usage. IMO that part should be split off of this PR and made into a new one.

addons/medical_status/XEH_PREP.hpp Outdated Show resolved Hide resolved
addons/medical_status/functions/fnc_getMedicationCount.sqf Outdated Show resolved Hide resolved
addons/medical_status/functions/fnc_getMedicationCount.sqf Outdated Show resolved Hide resolved
addons/medical_status/functions/fnc_getMedicationCount.sqf Outdated Show resolved Hide resolved
addons/medical_treatment/functions/fnc_overDose.sqf Outdated Show resolved Hide resolved
Cplhardcore and others added 13 commits October 23, 2024 17:51
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
LinkIsGrim
LinkIsGrim previously approved these changes Oct 25, 2024
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added listenable API event and additional args so hopefully there's no reason to overwrite this ever, but KAM uh, finds a way. Also fixed an undefined variable.

Not gonna ask for doc on the function call because it's not really done elsewhere, but would be nice.

@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Oct 25, 2024
@LinkIsGrim LinkIsGrim dismissed their stale review October 25, 2024 19:52

Issues found

@LinkIsGrim
Copy link
Contributor

@Cplhardcore making requested changes left as an exercise to the reader, please don't make me fix EOF newlines and headers again

Cplhardcore and others added 2 commits November 3, 2024 10:22
Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim LinkIsGrim merged commit e31aba5 into acemod:master Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants