Hearing - Add Electronic Hearing Protection #10476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
reviewed
Nov 4, 2024
LinkIsGrim
reviewed
Nov 4, 2024
Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
LinkIsGrim
approved these changes
Dec 13, 2024
johnb432
reviewed
Dec 15, 2024
|
|
||
| // Unequip electronic hearing protection when gear has one built in | ||
| if (_hasEHPOn && _hasBuiltInEHP) then { | ||
| [ACE_player, false] call FUNC(removeEHP); |
There was a problem hiding this comment.
If a unit's inventory is full and currently has EHP (from inventory item) equipped, then proceeds to equip a helmet with EHP built in, it won't remove the EHP. Do we care about that?
|
Stat preview, also fixed headgear not showing earpro stats, now requires #10559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
playSoundUIfor ear ringing to not mute it when EHP takes effectNoise reduction amount and duration were measured from this video: https://www.youtube.com/watch?v=4A30yaoj5Yo
Could be extended with a custom model, but looks odd when attached to head (see BI Feedback Tracker).
Would like to add a put on / take off sound later, but not a priority.