Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goggles - Add draw overlay setting #10484

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

SpicyBagpipes
Copy link
Contributor

@SpicyBagpipes SpicyBagpipes commented Nov 7, 2024

When merged this pull request will:

  • Title

Redo of 9896

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes
Copy link
Contributor Author

Easier to redo from scratch based on comments from previous PR

@veteran29
Copy link
Member

Why is it named draw overlay if it affects the effects only.

@LinkIsGrim LinkIsGrim added the kind/setting Release Notes: **SETTINGS:** label Nov 7, 2024
@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Nov 7, 2024
@SpicyBagpipes
Copy link
Contributor Author

Why is it named draw overlay if it affects the effects only.

My bad, fixed.

@LinkIsGrim LinkIsGrim merged commit 760e956 into acemod:master Nov 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants